Re: [PATCH] i8042 / PM: Allow PC keyboard to wake up from suspend-to-idle

[Rafael J. Wysocki]

On Monday, March 16, 2015 10:11:08 PM Pavel Machek wrote:
> On Tue 2015-03-10 00:08:43, Rafael J. Wysocki wrote:
> > On Monday, March 09, 2015 11:41:12 PM Rafael J. Wysocki wrote:
> > > On Monday, March 09, 2015 11:00:04 AM Dmitry Torokhov wrote:
> > > > Hi Rafael,
> > > > 
> > > > On Mon, Mar 09, 2015 at 04:19:50PM +0100, Rafael J. Wysocki wrote:
> > > > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > > > > 
> > > > > If they keyboard interrupt is registered, mark the i8042 platform
> > > > > device as wakeup-capable and check the user space wakeup setting in
> > > > > i8042_pm_suspend() and i8042_pm_resume() to enable or disable,
> > > > > respectively, the keyboard interrupt to wake up the system.
> > > > > 
> > > > > This makes it possible to use the PC keyboard to wake up the system
> > > > > from suspend-to-idle after writing "enabled" to the i8042 device's
> > > > > power/wakeup sysfs attribute.
> > > > 
> > > > Why do we do that for KBD but not AUX port? Should we mark individual
> > > > serio port be wakeup capable and not the whole i8042.
> > > 
> > > We can do that, but only after the port serio device has been registered.
> > > 
> > > I guess I can add code for that to i8042_register_ports().  Let me try that.
> > 
> > Yeah, that works too.  And you're right that there's no reason to do that for
> > keyboard only.
> 
> Actually, are you sure?
> 
> Resuming on mouse click is reasonable, resuming on mouse move is not,
> as table vibrations are likely to cause that.

This is disabled by default, so user space has to enable it anyway if it wants
to.

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/