Re: [PATCH 5/8] seqlock: Better document raw_write_seqcount_latch()

From: Peter Zijlstra
Date: Wed Mar 18 2015 - 10:51:29 EST


On Wed, Mar 18, 2015 at 02:29:35PM +0000, Mathieu Desnoyers wrote:
> > + * struct entry *latch_query(struct latch_struct *latch, ...)
> > + * {
> > + * struct entry *entry;
> > + * unsigned seq;
> > + * int idx;
>
> very minor nit: why is seq unsigned, but idx a signed int ?
> Could we do:
>
> unsigned seq, idx; instead ?
>
> Other than that:
>
> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>

Done and thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/