Re: [PATCH] x86, mce, severities: Add AMD severities function

[Borislav Petkov]

On Thu, Mar 19, 2015 at 12:01:32AM +0000, Luck, Tony wrote:
> One other thought.  Instead of the run-time test to see if this is an AMD processor on every call
> to this function, would it be cleaner to:
> 
> 1) Rename existing mce_severity() function to mce_severity_intel()
> 2) Declare a function pointer named mce_severity.
> 3) Assign that pointer to the _intel() or _amd() function in mce_init()

Yes, of course. We do that (or at least pretty close) in other paths
too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/