Re: [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails

From: Heikki Krogerus
Date: Thu Mar 19 2015 - 07:51:31 EST


> > @@ -65,6 +76,31 @@ static int dwc3_pci_quirks(struct pci_dev *pdev)
> > sizeof(pdata));
> > }
> >
> > + if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> > + pdev->device == PCI_DEVICE_ID_INTEL_BYT) {
> > + struct gpio_desc *gpio;
> > +
> > + acpi_dev_add_driver_gpios(ACPI_COMPANION(&pdev->dev),
> > + acpi_dwc3_byt_gpios);
> > +
> > + gpio = gpiod_get(&pdev->dev, "reset");
> > + if (IS_ERR(gpio))
> > + return 0;
> > +
> > + /* These GPIOs will turn on the USB2 PHY */
> > + gpiod_direction_output(gpio, 0);
> > + gpiod_set_value_cansleep(gpio, 1);
> > + gpiod_put(gpio);
> > +
> > + gpio = gpiod_get(&pdev->dev, "cs");
>
> CS GPIO should be handled before RESET.

OK, I'll fix it.


Thanks,

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/