Re: [PATCH 15/15] iscsi-target: don't export static symbol

From: Nicholas A. Bellinger
Date: Fri Mar 20 2015 - 14:48:49 EST


On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> drivers/target/iscsi/iscsi_target.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2155,7 +2155,6 @@ reject:
> cmd->text_in_ptr = NULL;
> return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
> }
> -EXPORT_SYMBOL(iscsit_handle_text_cmd);
>
> int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn)
> {
>

Applied to target-pending/for-next.

Thanks Julia!

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/