Re: [PATCH] ARM: print cma-reserved pages from show_mem

From: Russell King - ARM Linux
Date: Thu Mar 26 2015 - 09:23:26 EST


On Thu, Mar 26, 2015 at 12:30:29PM +0000, Mel Gorman wrote:
> On Thu, Mar 26, 2015 at 11:46:12AM +0000, Russell King - ARM Linux wrote:
> > <SNIP>
> >
> > Looking at Mel's commit, I don't see a reason why we couldn't use that
> > solution - it gets rid of walking the page array, which has been fraught
> > in the past due to ARM having platforms which have holes in their
> > physical memory.
> >
> > We could try that solution - I don't see much downside to it. Most of
> > that information is as debug information for MM stuff anyway, and IMHO
>
> >From an MM perspective, I can tell you that the information is close to
> useless for debugging anything. It's why I ditched it in that commit and
> AFAIK, no one has ever cared.

In that case, is there much point to show_mem()? Is it something which
should be considered for removal?

If code serves no useful purpose anymore, we really ought to have a way
to remove it.

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/