Re: [PATCH] mm/x86: AMD Bulldozer ASLR fix

From: Borislav Petkov
Date: Sun Mar 29 2015 - 05:55:46 EST


On Sun, Mar 29, 2015 at 10:51:22AM +0200, Ingo Molnar wrote:
> s/reduces the mmapped file's entropy by 3 bits
>
> Which does:
>
> - a grammar fix
>
> - measure it in bits, as later on we are talking about randomness in
> bits as well.

Fixed.

> Btw., does this limitation affect both executable and non-executable
> mmap()s?

Only executable mappings.

> Because data mmap()s don't need this I$ related workaround, right? So
> we could relax it for data-mmap()s?

Well, AFAIR, we wanted to keep this as less intrusive as possble. If
we're going to relax this, one way to solve it would be to pass down
@prot from do_mmap_pgoff() and friends to get_unmapped_area() which
would need to touch other arches.

I'm not sure it is worth it...

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/