Re: [PATCH] irqchip: renesas-intc-irqpin: Add optional functional clock to bindings

[Geert Uytterhoeven]

Hi Sergei,

On Wed, Mar 18, 2015 at 6:55 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
>> ---
>> a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
>> +++
>> b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt

>> +Example
>> +-------
>> +
>> +       irqpin1: irqpin@e6900004 {
>
>
>    The node name should be "interrupt-controller@e6900004".

Will fix (also the dtsi).

>> +               compatible = "renesas,intc-irqpin-r8a7740",
>> +                            "renesas,intc-irqpin";
>> +               #interrupt-cells = <2>;
>> +               interrupt-controller;
>> +               reg = <0xe6900004 4>,
>> +                       <0xe6900014 4>,
>> +                       <0xe6900024 1>,
>> +                       <0xe6900044 1>,
>> +                       <0xe6900064 1>;
>> +               interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH
>> +                             0 149 IRQ_TYPE_LEVEL_HIGH>;
>
>    Hm, 8 similar interrupts?

Yes, all interrupts are wired to the same parent on r8a7740.
However, the binding docs indeed don't mention that there should be
one entry per interrupt handled by the module. I'll fix that, too.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/