Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

From: David Vrabel
Date: Wed Apr 01 2015 - 06:18:56 EST


On 26/03/15 12:16, Bob Liu wrote:
> There are several place using gnttab async unmap and wait for
> completion, so move the common code to a function
> gnttab_unmap_refs_async_wait_completion().
>
[...]
> +
> +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item)

This name is a bit wordy. Can you rename it to:
gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or
gnttab_unmap_refs_safe().

(I can't decide which is the best name.).

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/