Re: [PATCH] x86/numa: kernel stack corruption fix

[Dave Young]

Hi, Xishi

[snip]
> >>  arch/x86/mm/numa.c |    3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> --- linux.orig/arch/x86/mm/numa.c
> >> +++ linux/arch/x86/mm/numa.c
> >> @@ -484,7 +484,8 @@ static void __init numa_clear_kernel_nod
> >>  
> >>  	/* Mark all kernel nodes. */
> >>  	for_each_memblock(reserved, r)
> >> -		node_set(r->nid, numa_kernel_nodes);
> 
> Hi Dave,
> 
> How about add some comment here? if set numa=off, numa_meminfo may not include
> all the memblock.reserved memory. e.g. trim_snb_memory()

Sure, I can do that. I will send an update if there's no other comments.

> >> +		if (r->nid != MAX_NUMNODES)
> >> +			node_set(r->nid, numa_kernel_nodes);
> >>  
> >>  	/* Clear MEMBLOCK_HOTPLUG flag for memory in kernel nodes. */
> >>  	for (i = 0; i < numa_meminfo.nr_blks; i++) {
> >>
> > 
> 

Thanks
Dave
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/