Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

[Ingo Molnar]

* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote:
> > So doesn't a 'nokaslr' boot option still make sense, to be able to 
> > debug KASLR failures and such?
> 
> That's still parsed in arch/x86/boot/compressed/aslr.c

So was this duplication dead code in essence?

> 
> > > +	if (kaslr_enabled())
> > > +		pr_emerg("Kernel Offset: 0x%lx from 0x%lx (relocation range: 0x%lx-0x%lx)\n",
> > > +			 (unsigned long)&_text - __START_KERNEL,
> > > +			 __START_KERNEL,
> > > +			 __START_KERNEL_map,
> > > +			 MODULES_VADDR-1);
> > > +	else
> > > +		pr_emerg("Kernel Offset: disabled\n");
> > 
> > Nit: curly braces for multi-line statements and so.
> 
> I guess by multi-line you mean multiple source lines...

Yeah.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/