Re: [PATCH RFC 06/10] dpaa_eth: add ethtool functionality

[Madalin-Cristian Bucur]

> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:
> > Add support for basic ethtool operations.
> 
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
> []
> > +static int __cold dpa_get_settings(struct net_device *net_dev,
> > +				   struct ethtool_cmd *et_cmd)
> > +{
> > +	int			 _errno;
> 
> Using a variable name of _errno is misleading at best,
> (btw: the only return value for phy_ethtool_gset is 0)

I'll rename all miss-used occurrences of _errno.
 
> > +static void __cold dpa_get_drvinfo(struct net_device *net_dev,
> > +				   struct ethtool_drvinfo *drvinfo)
> > +{
> > +	int		 _errno;
> > +
> > +	strncpy(drvinfo->driver, KBUILD_MODNAME,
> > +		sizeof(drvinfo->driver) - 1)[sizeof(drvinfo->driver) - 1] = 0;
> 
> That's a really odd and unusual construct
> more commonly written as strlcpy

I will change this.

> > +	_errno = snprintf(drvinfo->version, sizeof(drvinfo->version),
> 
> Using errno here is especially misleading as that's
> not the return value of an snprintf

I will take care of this one too.

Thank you,
Madalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/