Re: [PATCH V2 2/3] staging: android: ion_test: unregister the misc device

From: Greg KH
Date: Fri Apr 03 2015 - 09:13:33 EST


On Thu, Apr 02, 2015 at 09:36:06PM +0700, Phong Tran wrote:
> Add the remove() method for deregister from misc device
> when it's unloaded.
>
> Signed-off-by: Phong Tran <tranmanphong@xxxxxxxxx>
> ---
> drivers/staging/android/ion/ion_test.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/android/ion/ion_test.c b/drivers/staging/android/ion/ion_test.c
> index 3bc461c..d6a9653 100644
> --- a/drivers/staging/android/ion/ion_test.c
> +++ b/drivers/staging/android/ion/ion_test.c
> @@ -261,7 +261,19 @@ static int __init ion_test_probe(struct platform_device *pdev)
> return 0;
> }
>
> +static int ion_test_remove(struct platform_device *pdev)
> +{
> + struct ion_test_device *testdev;
> +
> + testdev = platform_get_drvdata(pdev);
> + if (!testdev)
> + return -ENODATA;
> +
> + return misc_deregister(&testdev->misc);

Extra space here :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/