Re: [PATCH v2] crypto: remove instance when test failed

From: Herbert Xu
Date: Fri Apr 03 2015 - 11:52:57 EST


On Fri, Apr 03, 2015 at 05:17:13PM +0200, Stephan Mueller wrote:
>
> Wpuldn't crypto_del_alg suffer from the same issue? I see that the cra_refcnt
> is checked. But I guess there would be the same kind of race?

You're quite right. It too needs to take a ref count on the
algorithm in crypto_alg_match before releasing the mutex.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/