Re: [PATCH] drm/msm: fix build warning - missing prototype

[Nicholas Mc Guire]

On Sat, 04 Apr 2015, Rob Clark wrote:

> On Fri, Apr 3, 2015 at 10:39 PM, Nicholas Mc Guire <hofrat@xxxxxxxxx> wrote:
> > fix build warning when building edp/edp_aux.o due to missing
> > prototype for edp_aux_transfer.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> > ---
> > building drivers/gpu/drm/msm/msm.ko gives the following warning:
> > drivers/gpu/drm/msm/edp/edp_aux.c:118:9: warning: no previous prototype for 'edp_aux_transfer' [-Wmissing-prototypes]
> >  ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg)
> >          ^
> >
> 
> thx.. fwiw, looks like edp_aux_transfer is only used in that one
> file.. so probably it actually wants to be static instead..
>
yup - missed that - making it static is the cleaner solution 
will resend.

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/