Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN

From: Arnd Bergmann
Date: Mon Apr 06 2015 - 10:41:09 EST


On Sunday 05 April 2015 16:59:24 Geert Uytterhoeven wrote:
> If CONFIG_IRQ_DOMAIN=n:
>
> drivers/of/irq.c: In function âof_irq_getâ:
> drivers/of/irq.c:406: error: implicit declaration of function âirq_find_hostâ
> drivers/of/irq.c:406: warning: assignment makes pointer from integer without a cast
> make[2]: *** [drivers/of/irq.o] Error 1
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> drivers/of/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 4c98f14694458794..92adecd3ecb28fc7 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI
>
> config OF_IRQ
> def_bool y
> - depends on !SPARC
> + depends on !SPARC && IRQ_DOMAIN
>
> config OF_NET
> depends on NETDEVICES
>

Sparc does not set IRQ_DOMAIN, so we can probably simplify this to

config OF_IRQ
def_bool IRQ_DOMAIN

unless you want to keep the sparc antidependency explicit.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/