Re: [PATCH] mac80211: Move message tracepoints to their own header

From: Johannes Berg
Date: Tue Apr 07 2015 - 02:59:31 EST


On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote:
> Every tracing file must have its own TRACE_SYSTEM defined.

Oh, that requirement is new to me. I also have the same in iwlwifi, with
even more TRACE_SYSTEMs.

> The mac80211 tracepoint header broke this and add in the middle
> of the file had:
>
> #undef TRACE_SYSTEM
> #define TRACE_SYSTEM mac80211_msg
>
> Unfortunately, this broke new code in the ftrace infrastructure.
> Moving the mac80211_msg into its own trace file with its own
> TRACE_SYSTEM defined fixes the issue.



> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Looks fine to me.

Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

I could merge through my tree but I guess you'll want to put it through
a different one to be able to change the code that depends on this move.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/