Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible

From: Alexander Kuleshov
Date: Tue Apr 07 2015 - 13:30:46 EST


What do you think about following way to solve this:

1. To move this code: -
https://github.com/torvalds/linux/blob/master/arch/x86/kernel/setup.c#L971-L982
to the separate function, something like setup_cmdline().

2. Call setup_cmdline in head{32,64}.c and call
setup_early_printk(boot_command_line)
right after this.

After execution of the setup_cmdline, boot_command_line will be in
actual state. It will contain
command line which we passed to the kernel directly, or overwriten
with CONFIG_CMDLINE_OVERRIDE,
or appended with CONFIG_CMDLINE_OVERRIDE.

What do you think about this?

I already did it and tested on my local machine and it works, but
maybe I have missed something important.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/