Re: [PATCH 1/2] perf data: Show error message when ctf setup failed

From: He Kuang
Date: Thu Apr 09 2015 - 04:20:23 EST

Hi, jirka
On 2015/4/9 1:45, Jiri Olsa wrote:
On Wed, Apr 08, 2015 at 12:49:19PM +0800, He Kuang wrote:
Show message when errors occurred during ctf conversion setup.

Before this patch:
$ ./perf data convert --to-ctf=ctf
$ echo $?

After this patch:
$ ./perf data convert --to-ctf=ctf
Error during CTF convert setup.
so I have like 5 more patches from the original CTF set
which I'm holding until all works with tracecompass:

Is it working for you? How do you test resulted CTF data?

anyway the patch looks ok, just small nit below

I tested by using babeltrace binary and it works.

After receiving your reply, I test on the latest tracecompass. A
folder named 'ctf' is showed instead of the expected file
'ctf-data', this folder only contains the raw metadata and
perf-stream files but not analysed.
Signed-off-by: He Kuang <hekuang@xxxxxxxxxx>
tools/perf/util/data-convert-bt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index dd17c9a..a5b89b9 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -847,11 +847,15 @@ int bt_convert__perf2ctf(const char *input, const char *path, bool force)
(double) c.events_size / 1024.0 / 1024.0,
- /* its all good */
+ ctf_writer__cleanup(cw);
this leg can also fail due to:

err = perf_session__process_events(session);
if (!err)
err = bt_ctf_stream_flush(cw->stream);

so we might want to inform about that like:
if (err)
pr_err("Error during conversion.\n");


+ return err;
+ perf_session__delete(session);
+ pr_err("Error during CTF convert setup.\n");
return err;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at