Re: [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable

From: Greg KH
Date: Thu Apr 09 2015 - 05:31:50 EST


On Wed, Apr 08, 2015 at 04:36:00PM -0700, Matthew Garrett wrote:
> Windows appears to pay more attention to the ACPI values than any hub
> configuration, so prefer the firmware's opinion on whether a port is
> fixed or removable before falling back to the hub values.
>
> Signed-off-by: Matthew Garrett <mjg59@xxxxxxxxxx>
> ---
> drivers/usb/core/hub.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)

I like your trust in firmware :)

Anyway, is this all a Windows 8 requirement? If so, I'll feel
comfortable making these changes, otherwise we are at the mercy of the
bios people to randomly get things right, and we all know how often that
works...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/