Re: [PATCH] regulator: kconfig: make max8973 driver to depend on GPIOLIB

From: Laxman Dewangan
Date: Thu Apr 09 2015 - 06:05:36 EST

On Wednesday 08 April 2015 10:13 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Wed, Apr 08, 2015 at 07:07:07PM +0530, Laxman Dewangan wrote:
MAX8973 regulator driver uses the GPIO APIs for accessing the
control signal connected to its pin from host processor.

Make this driver depends on GPIOLIB.
The GPIO usage in the driver appears to be optional, it handles the GPIO
not being controllable. This suggests to me that the gpiolib dependency
shouldn't be required and that it would be better to fix this by
ensuring that all the gpiolib functions being used have appropriate
stubs. Which ones are causing problems?

Thanks for review.

Sometime ago, I got the comiplation error on random config for one of architecture which was not having GPIO architecture. The compilation error was reported on tps62360-regulator.c which is also using similar i2c calls.

So to avoid similar issue, I make this depends on GPIOLIB.

However, I looked gpio.h and it has all required APIs as static inline if GPIOLIB is not there so atleast compilation issue will not be there.

Now going through code, I think if gpios are not there then also it should work.
Not tested this on my board as I can not boot without gpio.

I think we can drop this patch.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at