Re: [PATCH v4 1/2] nohz: add tick_nohz_full_cpumask_or() and _andnot() APIs
From: Peter Zijlstra
Date: Thu Apr 09 2015 - 13:07:57 EST
On Thu, Apr 09, 2015 at 01:00:38PM -0400, Chris Metcalf wrote:
> +static inline void tick_nohz_full_cpumask_or(struct cpumask *mask)
This still reads as if you're doing: nohz_full_mask |= mask.
I think the suggestion done by Frederic is the right one, reverse the
isolcpu_map_or(nohz_full_map) := isolcpus_map |= nohz_full_map
Or just completely give up and just write readable code under an #ifdef.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/