Re: [PATCH] mips: Fix build if PERF_EVENTS is configured
From: Ralf Baechle
Date: Fri Apr 10 2015 - 10:05:47 EST
On Wed, Apr 08, 2015 at 08:40:08PM -0700, Guenter Roeck wrote:
> >>kernel/events/core.c:4828: undefined reference to `perf_get_regs_user'
> >>The problem is caused by commit 3478e32c1545 ("MIPS: Add user stack and
> >>registers to perf.") in combination with commit 88a7c26af8da ("perf:
> >>Move task_pt_regs sampling into arch code"), which introduces
> >>Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> >>Cc: David Daney <david.daney@xxxxxxxxxx>
> >>Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >I've already applied the same change locally but due to patch ordering
> >constraints I'm considering to temporarily pull this patch until the
> >perf stuff and the remainder of the MIPS changes are in 4.1 or so.
> Hi Ralf,
> Does it hurt to have the function if 88a7c26af8da is not in the tree ?
> Sure, you'll get a smatch and/or sparse warning, but I would consider that
> to be less severe than build failures.
There are other dependencies between the pending MIPS perf patches, the
remainder of the pending MIPS patches and upstream perf patches for 4.1
and all in all I've decided it's too much headache and I should rather wait.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/