Re: [PATCH v2 4/6] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC

[Bintian]

Hello Arnd,

Thanks for your code review.

On 2015/4/13 21:30, Arnd Bergmann wrote:
> On Monday 13 April 2015 17:17:38 Bintian Wang wrote:
> > +#define HI6220_CFG_CSI2PHY     8
> > +#define HI6220_ISP_SCLK_GATE   9
> > +#define HI6220_ISP_SCLK_GATE1  10
> > +#define HI6220_ADE_CORE_GATE   11
> > +#define HI6220_CODEC_VPU_GATE  12
> > +#define HI6220_MED_SYSPLL      13
> > +
> > +/* mux clocks */
> > +#define HI6220_1440_1200       20
> > +#define HI6220_1000_1200       21
> > +#define HI6220_1000_1440       22
> > +
> > +/* divider clocks */
> > +#define HI6220_CODEC_JPEG      30
> > +#define HI6220_ISP_SCLK_SRC    31
> > +#define HI6220_ISP_SCLK1       32
>
> The numbers seem rather arbitrary, and you have both holes as well as duplicate
> numbers here. I would suggest you do one of two things instead:
I just worry about some special clocks may be added later so keep some
holes for them;

The duplicate numbers means clocks belong to different system control
domains.
> a) have a separate header file per clock driver and make all the
>     numbers unique and consecutive within that header
>
> b) use the same numbers as the hardware registers so you can put the
>     numbers directly into the dts and don't need a header to create
>     an artificial ABI between the clock driver and the boot loader.
This header file will be used by device tree (I like using the clock
name instead "magic number" in dts :) ), so how about keep them in one
header file and let dts just include one header file (not four files),
but remove the holes?

Thank you Arnd.

BR,

Bintian
> 	Arnd
>
> .

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/