Re: [PATCH v3 04/28] IB/Verbs: Reform IB-core cm

From: Michael Wang
Date: Tue Apr 14 2015 - 03:57:16 EST

On 04/13/2015 09:29 PM, Jason Gunthorpe wrote:
> On Mon, Apr 13, 2015 at 06:40:35PM +0000, Hefty, Sean wrote:
>>>> - if (rdma_node_get_transport(ib_device->node_type) !=
>>>> - return;
>>>> + int count = 0;
>>> I'm ok with this as an intermediate patch but going forward if we are
>>> going to
>>> have calls like
>>> static inline int cap_ib_cm_dev(struct ib_device *device)
>> I would rather keep everything to checking per port, not per device.
>> Specifically, because we have code that does this:
> Argee.
> I asked Michael for it and stand by it, the property is per-port, not
> per device. Having the per-device tests just muddles the logic, look
> at the trouble Sean notices in #10 when we are now forced to think of
> things clearly.

The only per-dev checking left is all included in #24 (now may be #10 too),
which is inside:

1. cma_listen_on_dev
2. ib_ucm_add_one

I can't find a good way to apply per-port check in this two, seems like
they are at the stage which not related to port yet... any ideas on how
to improve that?

Michael Wang

> Jason
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at