Re: I_CLEAR bug while shrinking dcache

From: Samuel Thibault
Date: Tue Apr 14 2015 - 10:44:14 EST


Al Viro, le Tue 14 Apr 2015 13:44:29 +0100, a écrit :
> On Tue, Apr 14, 2015 at 10:12:54AM +0200, Samuel Thibault wrote:
> > So it seems that shrink_dentry_list was trying to kill an inode which
> > already has I_CLEAR. I'll be trying the attached patch in the next
> > days.
>
> That patch is just papering over the problem.

I never said it was a proper fix :)

> The first variant can happen, but in that case it should have had
> DCACHE_DENTRY_KILLED set by said __dentry_kill() and skipped. The other
> two are clear inode refcounting bugs.
>
> Do you have a reproducer for that?

It just happened in the middle of the night.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/