Re: [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs

[Matias BjÃrling]

On 04/16/2015 01:34 PM, Paul Bolle wrote:
> On Thu, 2015-04-16 at 12:23 +0200, Matias BjÃrling wrote:
> > On 04/16/2015 11:10 AM, Paul Bolle wrote:
> > > A few things I spotted (while actually fiddling with 3/5).
> >
> > Thanks. I'll fix them up.
>
> Please note that just using #ifdef instead of #if is not all that's
> needed. See, I had some fun playing whack-a-mole with warnings and
> errors showing up in the "CONFIG_BLK_DEV_NVM is not set" case (because I
> was looking into things outside of this series that I don't understand).
>
> After adding the changes pasted at the end of this message (which I gave
> almost no thought whatsoever) I ran into:
>      block/blk-mq.c: In function âblk_mq_init_rq_mapâ:
>      block/blk-mq.c:1473:22: error: invalid application of âsizeofâ to incomplete type âstruct nvm_per_rqâ
>         cmd_size += sizeof(struct nvm_per_rq);
>                            ^
>
> Then I admitted defeat.
>
> Have fun with your turn of that game.

Thanks. Nothing like a good whack-a-mole. I've fixed it up in the master at:

  https://github.com/OpenChannelSSD/linux.git

Keith, for the nvme driver, I've packed everything neatly into a #ifdef, 
so it looks the same as with the #ifdef integrity. It should have been 
like that from the start.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/