Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

From: Boris Brezillon
Date: Fri Apr 17 2015 - 04:34:21 EST


Hi Jason,

On Mon, 13 Apr 2015 20:11:46 +0000
Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:

> >
> > > I'd appreciate if we'd look into it. I understand from on-list and
> > > off-list discussion that the rewrite was unavoidable. So I'm willing to
> > > concede that. Giving people time to migrate from old to new while still
> > > being able to update for other security fixes seems reasonable.
> >
> > Jason, what do you think of the approach above?
>
> I say keep it simple. We shouldn't use the DT changes to trigger one
> vice the other. We need to be able to build both, but only load one at
> a time. If that's anything other than simple to do, then we make it a
> Kconfig binary choice and move on.

Actually I was planning to handle it with a Kconfig dependency rule
(NEW_DRIVER depends on !OLD_DRIVER and OLD_DRIVER depends
on !NEW_DRIVER).
I don't know how to make it a runtime check without adding new
compatible strings for the kirkwood, dove and orion platforms, and I'm
sure sure this is a good idea.
Do you have any ideas ?

Regards,

Boris


--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/