Re: [PATCH] crypto: ensure backlog is initialised

From: Herbert Xu
Date: Sat Apr 18 2015 - 07:00:17 EST


On Tue, Apr 14, 2015 at 11:51:29AM -0500, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> backlog is not initialised so in the case where
> cpg->eng_st != ENGINE_IDLE it is never initialised and
> hence which could lead to an illegal memory dereference
> in the statement:
>
> backlog->complete(backlog, -EINPROGRESS);
>
> Discovered with cppcheck static analsys:
> [drivers/crypto/mv_cesa.c:616]:
> (error) Uninitialized variable: backlog
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/