Re: panic with CPU hotplug + blk-mq + scsi-mq

From: Dongsu Park
Date: Mon Apr 20 2015 - 14:36:33 EST


On 21.04.2015 00:48, Ming Lei wrote:
> Thanks for providing that.
> The trick is just in CPU number and virito-scsi hw queue number,
> and that is why I asked that, :-)
> Now the problem is quite clear, before CPU1 online, suppose
> CPU3 is mapped hw queue 6, and CPU 3 will map to hw queue 5
> after CPU1 is offline, unfortunately current code can't allocate
> tags for hw queue 5 even it becomes mapped.
> The following updated patch(include original patch 2) will fix
> the problem, and patch 1 is required too.
> So the following patch should fix your hotplug issue.

Yes, it works indeed. Thanks a lot! :-)
You can add:

Tested-by: Dongsu Park <dongsu.park@xxxxxxxxxxxxxxxx>

As the original patch didn't apply, I had to change some nitpicks though.
(see below)

Cheers,
Dongsu

----