Re: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths

From: Dan Carpenter
Date: Tue Apr 21 2015 - 05:05:23 EST


On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote:
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index 54da66d..836386f 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
> list_del(&open_info->msglistentry);
> spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags);
>
> - if (err == 0)
> - newchannel->state = CHANNEL_OPENED_STATE;
> + if (err != 0)

Doesn't the double negative not make it slightly more confusing?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/