[PATCH 3.16.y-ckt 139/144] hpsa: fix memory leak in kdump hard reset

From: Luis Henriques
Date: Tue Apr 21 2015 - 11:35:48 EST


3.16.7-ckt10 -stable review patch. If anyone has any objections, please let me know.

------------------

From: Tomas Henzl <thenzl@xxxxxxxxxx>

commit 03741d956eaac31264952e0afa181b62713892a5 upstream.

There is a potential memory leak in hpsa_kdump_hard_reset_controller.

Reviewed-by: Don Brace <don.brace@xxxxxxxx>
Reviewed-by: Scott Teel <scott.teel@xxxxxxxx>
Signed-off-by: Tomas Henzl <thenzl@xxxxxxxxxx>
Signed-off-by: Don Brace <don.brace@xxxxxxxx>
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Cc: Masoud Sharbiani <msharbiani@xxxxxxxxxxxxxxxx>
Cc: Vinson Lee <vlee@xxxxxxxxxxxxxxxx>
Signed-off-by: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 28533dbd3407..35996a829046 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5995,7 +5995,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
}
rc = write_driver_ver_to_cfgtable(cfgtable);
if (rc)
- goto unmap_vaddr;
+ goto unmap_cfgtable;

/* If reset via doorbell register is supported, use that.
* There are two such methods. Favor the newest method.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/