Re: [PATCH] net: mdio-gpio: support access that may sleep
From: David Miller
Date: Fri Apr 24 2015 - 11:05:12 EST
From: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 22 Apr 2015 13:06:54 -0400
> Some systems using mdio-gpio may use gpio on message based busses, which
> require sleeping (e.g. gpio from an I2C I/O expander).
> Since this driver does not use IRQ handler, it is safe to use the
> _cansleep suffixed gpio accessors.
> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
Since this is down underneath the layer of an MII bus, you cannot
universally say that these routines are always called in a sleepable
The PHY layer, and the driver itself above that, might call these
routines from timers, interruptes etc.
In fact, since the whole point of this driver is to provide a specific
implementation for programming registers over an MII bus, it's quite
rediculuous to say that just because interrupts are not used in this
implementation it means that sleeping is always valid.
You have to look at all of the (real and potential) users, all the way
up into the specific ethernet drivers.
Sorry I'm not applying this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/