[PATCH] input: goodix: Check the 'data ready' bit before reading data

From: Paul Cercueil
Date: Sat Apr 25 2015 - 06:48:29 EST

The MSB of the first byte read via I2C seems to indicate whether the
data is valid (or ready) when an interrupt is raised. Previously, this
bit was ignored, which resulted in a lot of incorrect detections of
"finger removed" events.

Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
drivers/input/touchscreen/goodix.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index ca19668..9fa6c5f 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -98,6 +98,9 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data)
return error;

+ if (!(data[0] & 0x80))
+ return -EAGAIN;
touch_num = data[0] & 0x0f;
if (touch_num > GOODIX_MAX_CONTACTS)
return -EPROTO;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/