Compiler warning about comparing result of !!test_bit() to an integer

From: David Howells
Date: Mon Apr 27 2015 - 10:13:38 EST

Hi Jiri,

This line in hid-input.c:

if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
input_event(input, EV_MSC, MSC_SCAN, usage->hid);


../drivers/hid/hid-input.c: In function 'hidinput_hid_event':
../drivers/hid/hid-input.c:1160:167: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]

with gcc-5.1. Given that 'value' doesn't appear to be a boolean, is this correct?

This was introduced by commit c01d50d181f074a60bf3ed54eb055ce1679afb98.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at