Re: [PATCH v2 0/3] leds: blink resolution improvements
From: Stas Sergeev
Date: Tue Apr 28 2015 - 06:12:37 EST
28.04.2015 11:57, Jacek Anaszewski ÐÐÑÐÑ:
> Hi Stas,
> Have you tested it?
Of course I did.
Works with gpio driver and provides up to 10usec precision on
This is 1000 times better than without my patch - the precision
was 10ms (jiffy).
> I tried it with Samsung M0 board and
> my leds-aat1290 driver. It didn't work well. And for small delay
> intervals it will not have a chance to work reliably with all drivers,
> especially the ones which use mutex in their brightness_set op,
> since mutex can sleep.
OK, I can remove the nsec resolution.
I added it for the future, it doesn't work for me either, but
hrtimer has an API for it, so I thought it may work on another hw.
I don't see why it can't stay, but if it bothers you that much,
I'll remove it.
> I am afraid that we have to stay with what we have currently.
This is a counter-productive conclusion.
My patch does 1000 times precision improvement with gpio driver.
If you only want nsec to be removed as it doesn't work - that's
fine with me.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/