Re: [PATCH 02/10] block: simplify bio_add_page()

From: Christoph Hellwig
Date: Tue Apr 28 2015 - 08:12:44 EST

On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote:
> Note that removing call to ->merge_bvec_fn() is fine for
> bio_add_pc_page(), as SCSI devices usually don't even need that.
> Few exceptional cases like pscsi or osd are not affected either.

This explanation confuses me. Based on my reading of the code I'd
replace it with something like:

Removing the call to ->merge_bvec_fn() is also fine, as no driver that
implements support for BLOCK_PC commands even has a ->merge_bvec_fn()
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at