Re: [PATCH] iwl4965: Enable checking of format strings

From: Kalle Valo
Date: Tue Apr 28 2015 - 12:19:15 EST

Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes:

> Since these fmt_* variables are just const char*, and not const
> char[], gcc (and smatch) doesn't to type checking of the arguments to
> the printf functions. Since the linker knows perfectly well to merge
> identical string constants, there's no point in having three static
> pointers waste memory and give an extra level of indirection.
> This removes over 100 "non-constant format argument" warnings from
> smatch, accounting for about 20% of all such warnings in an
> allmodconfig.
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

So what's the conclusion, should I commit this patch or not?

Full discussion here:

Kalle Valo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at