Re: [PATCH v6 0/4] Fix bugs in kona pwm driver and pwm core
From: Jonathan Richardson
Date: Tue Apr 28 2015 - 17:06:21 EST
Pinging maintainer and others. Could you please let me know when you can
provide feedback on this patchset.
Tim, were you ok with these changes now or do you still have concerns
about changing the driver? I didn't hear back from after our last
conversation. If there are still concerns we could possibly make a new
cygnus pwm driver, though it would be mostly the same as the existing
kona driver. Or add a DT version to the existing driver that has the new
modified behaviour - though I think this would be messy.
On 15-04-10 11:58 AM, Jonathan Richardson wrote:
> This patchset fixes a number of bugs in the Broadcom Kona pwm driver. It also
> fixes a bug in the pwm core where the enabled state was incorrect on failed
> calls to enable. Also, a new function was added to the pwm core to add pwm chips
> with inversed polarity for chips that have a different default polarity than the
> core. The prevents incorrect polarity being reported.
> These changes are required for the Kona pwm driver to work on Cygnus and the
> same pwm IP is being used.
> Changes from v5:
> - Address Dmitry's comment on code cleanup of pwm_enable() in pwm core.
> - Including all patches from different contributors in this patchset. Some
> were left out in v4.
> Changes from v4:
> - Rebased to Tim Kryger's patch that adds support in pwm core to add driver
> with inversed polarity.
> - Removed patch 2 that resolved difference between hardware default polarity
> and pwm framework default polarity. The default polarity is set properly now
> when the pwm driver is registered with the pwm framework.
> Arun Ramamurthy (1):
> drivers: pwm: bcm-kona: Dont set polarity in probe
> Jonathan Richardson (2):
> pwm: kona: Fix incorrect config, disable, and polarity procedures
> pwm: core: Set enable state properly on failed call to enable
> Tim Kryger (1):
> drivers: pwm: core: Add pwmchip_add_inversed
> drivers/pwm/core.c | 52 +++++++++++++++++++++------
> drivers/pwm/pwm-bcm-kona.c | 84 +++++++++++++++++++++++++++++++++-----------
> include/linux/pwm.h | 6 ++++
> 3 files changed, 110 insertions(+), 32 deletions(-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/