Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

From: Pali RohÃr
Date: Wed Apr 29 2015 - 12:29:19 EST


On Wednesday 29 April 2015 15:57:58 Gabriele Mazzotta wrote:
> On Wednesday 29 April 2015 15:08:40 Pali RohÃr wrote:
> > On Wednesday 29 April 2015 12:30:32 Gabriele Mazzotta wrote:
> > > On Wednesday 29 April 2015 11:51:04 Pali RohÃr wrote:
> > > > This is an ACPI driver for Dell laptops which receive HW switch events.
> > > > It exports rfkill device dell-rbtn which provide correct hard rfkill state.
> > > >
> > > > Alex Hung added code for supporting Dell laptops which have toggle button
> > > > instead HW slider switch. On these laptops toggle button event is reported
> > > > by new input device (instead rfkill) as they do not have hw radio switch.
> > > >
> > > > It looks like those are two different functions (rfkill, input device), but
> > > > Dell BIOS exports them via same ACPI device and uses same ACPI functions.
> > > > So code is in one kernel driver.
> > >
> > > I made a patch some time ago that I've just adapted. It allows to
> > > prefer RBTN_SLIDER over RBTN_TOGGLE. The main reason why I'd like to
> > > have the hardware switch is that the BIOS doesn't alter the soft state
> > > of the devices. This comes in handy when the function key controls
> > > multiple radio devices.
> > >
> >
> > Now I'm thinking... is't this bug in wifi kernel driver (which exports
> > phy rfkill)? Or problem somewhere else (userspace or kernel)?
>
> What is the presumed bug you are referring to? The fact that the soft state
> doesn't change?

Can you remind me whats the problem on your laptop?

--
Pali RohÃr
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/