Re: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq

From: Linus Walleij
Date: Wed Apr 29 2015 - 17:49:03 EST

On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold <johan@xxxxxxxxxx> wrote:

> Drop redundant lock-as-irq in gpio_setup_irq, which has already been
> handled when requesting and releasing the irq (i.e. in the irq chip
> irq_request_resources and irq_release_resources callbacks).

Well we would hope they all do that. And I hope for the vast majority
that is true, but there is a TODO to go over all gpiochip drivers
(some which are elsewhere in the kernel than drivers/gpio) and
make sure they actually do so.

Right now it's a bit arbitrary if so happens, and in not marked by
the driver as IRQ then this kicks in and provides an additional

But maybe that's overzealous, what do people say?

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at