Re: [PATCH kernel v9 09/32] vfio: powerpc/spapr: Rework groups attaching

From: David Gibson
Date: Thu Apr 30 2015 - 00:38:39 EST

On Thu, Apr 30, 2015 at 12:29:30PM +1000, Alexey Kardashevskiy wrote:
> On 04/29/2015 12:16 PM, David Gibson wrote:
> >On Sat, Apr 25, 2015 at 10:14:33PM +1000, Alexey Kardashevskiy wrote:
> >>This is to make extended ownership and multiple groups support patches
> >>simpler for review.
> >>
> >>This should cause no behavioural change.
> >
> >Um.. this doesn't appear to be true. Previously removing a group from
> >an enabled container would fail with EBUSY, now it forces a disable.
> This is the original tce_iommu_detach_group() where I cannot find EBUSY you
> are referring to; it did and does enforce disable. What do I miss
> here?

Sorry, my mistake. I misread the patch.

David Gibson | I'll have my music baroque, and my code
david AT | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!

Attachment: pgpszcrJU_8TH.pgp
Description: PGP signature