Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro
From: mancha security
Date: Thu Apr 30 2015 - 01:59:15 EST
On Wed, Apr 29, 2015 at 12:40:15PM -0400, Pranith Kumar wrote:
> On Wed, Apr 29, 2015 at 10:59 AM, mancha security <mancha1@xxxxxxxx>
> > The problem is that ICC defines __GNUC__ so barrier() gets defined
> > in compiler-gcc.h. Your commit removed an #undef from
> > compiler-intel.h so compiler.h will never define barrier to
> > __memory_barrier().
> OK, I see your point. But, ICC has support for GCC inline assembly. So
> the change does not seem to be making any difference. We are using our
> own asm barrier rather than the inbuilt one provided by ICC.
> -- Pranith
Yes, I misspoke earlier and meant to say ECC rather than ICC.
Description: PGP signature