Re: [PATCH V2] drivers: CCI: fix used_mask init in validate_group()
From: Mark Salter
Date: Thu Apr 30 2015 - 09:27:13 EST
On Thu, 2015-04-30 at 11:55 +0100, Suzuki K. Poulose wrote:
> On 13/04/15 13:41, Will Deacon wrote:
> > On Thu, Apr 09, 2015 at 04:36:29PM +0100, Mark Rutland wrote:
> >> On Thu, Apr 09, 2015 at 03:57:05PM +0100, Mark Salter wrote:
> >>> Currently in validate_group(), there is a static initializer
> >>> for fake_pmu.used_mask which is based on CPU_BITS_NONE but
> >>> the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS.
> >>> CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE
> >>> is not correct and will cause a build failure if NR_CPUS
> >>> is set high enough to make CPU_BITS_NONE larger than used_mask.
> >>> Signed-off-by: Mark Salter <msalter@xxxxxxxxxx>
> >> Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>
> >> Arnd, Olof, are you happy to take this via arm-soc?
> >> My (broken) patch went via Will's tree because of a perf dependency, but
> >> other CCI patches have gone via you guys.
> > Yeah, arm-soc is the best place for this. You should resend to
> > arm@xxxxxxxxxx as a new patch with the relevant acks.
> Could you please send this to arm-soc as suggested by Will, with the
> relevant acks/reviews ?
I sent it on Tuesday. Did it not show up? Is arm@xxxxxxxxxx the correct
address? I got the cc:
From: Mark Salter <msalter@xxxxxxxxxx>
Cc: Mark Salter <msalter@xxxxxxxxxx>
Subject: [PATCH V2] drivers: CCI: fix used_mask init in validate_group()
Date: Tue, 28 Apr 2015 13:09:32 -0400
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/