Re: [PATCH v6] block: loop: avoiding too many pending per work I/O

From: Christoph Hellwig
Date: Fri May 01 2015 - 11:05:56 EST


On Fri, May 01, 2015 at 10:22:21AM -0400, Tejun Heo wrote:
> > > Why would you do this fall back? Shouldn't we just communicate
> > > a concurrency limit to the workqueue code?
> >
> > It can't work with workqueue's concurrency limit because the
> > queue is shared by all loop block devices, and the limit is on the
> > whole queue.
>
> Maybe just cap max_active to NR_OF_LOOP_DEVS * 16 or sth? But idk,
> how many concurrent workers are we talking about and why are we
> capping per-queue concurrency from worker pool side instead of command
> tag side?

Also we probably should have per device workqueues to start with..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/