Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant

From: Kenneth Westfield
Date: Sat May 02 2015 - 19:58:22 EST


On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote:
> Some LPASS integrations like on APQ8016 do not have OSR clk, so adding
> no osr clk bit would allow such integrations to use lpass driver.

Going forward, as the code is generalized, perhaps having an enable flag
for each clock, rather than a flag that negates an existing clock?
Or checking that the clock pointer is NULL after probing would be the
indication?

> sound/soc/qcom/lpass-cpu.c | 49 +++++++++++++++++++++++++++++-----------------
> sound/soc/qcom/lpass.h | 2 ++
> 2 files changed, 33 insertions(+), 18 deletions(-)

--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/