Re: [PATCH v2 0/3] leds: blink resolution improvements

[Stas Sergeev]

03.05.2015 13:34, Pavel Machek ÐÐÑÐÑ:
> > > What about simply "echo 0.001 > delay_on"?
> > This is possible.
> > But please consider the following reservations:
> > - There is already 2 files, so you are not going to write settings
> > atomically anyway. When resolution changes, it might be better
> > to just reset to the sane defaults (not in my current patch).
> Sane defaults would be mandatory, but lets get reasonable interface.
>
> Someone left 1 in delay_on. You want 100 nsec. You echo nsec >
> delay_on_units, bang, dead machine, looping in kernel.
That's exactly what the aforementioned "reset to the sane defaults"
should solve: if you change the delay_units, all delays should
reset to the sane defaults. FYI, there was no "delay_on_units",
just "delay_unit" for both ON and OFF delays.

> Someone left 100 / nsec in delay on. You want one usec. Echo 1 >
> delay_on, bang, dead machine.
There are 2 things needed to address this:
1. No interface should allow a michine lock-up. Locking up the
machine by writing 0.000000001 is just as bad as by writing
"nsec" and then "1". So I'll simply remove nsecs, regardless of
what interface I'll end up implementing.
2. Since changing "delay_unit" should reset the delays to the
sane default, the user should always write the delay_unit first,
then the value.

> > - As was already discussed in the same thread, not all drivers
> > can support sub-ms delays. For these drivers such resolutions
> > should not be available. With separate file this is naturally
> > achieved: you either don't create it at all, or list only the possible
> > resolutions. With your approach you never know whether you
> > can write 0.0001 or not.
> Well, so you get back einval. Knowing "unit" is not enough to know how
> short delays hw can support.
The idea was that you can at least find out the order of the
supported delay. But indeed checking for EINVAL looks like a
more robust and precise solution.

> > - You will set the delay in ms units. For example for 100us you'll
> > write 0.1. IMHO it is counter-intuitive: people will make a mistake
> > and try 0.0001 instead, wrongly assuming that this is in seconds.
> > And nanoseconds should then better be removed, as writing
> > nanosecond delay will just require too much zeros.
> This is machine-to-machine interface. And users can handle this.
OK. I think you mostly convinced me that this solution is not
that bad. :) But I am going to add an explicit "Acked-by" then,
to emphasize that it is your idea and not mine.

I'll post a v3 a couple of weeks later, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/