Re: [PATCH] hostfs: Use correct mask for file mode

From: Geert Uytterhoeven
Date: Mon May 04 2015 - 09:22:24 EST


On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger <richard@xxxxxx> wrote:
> --- a/fs/hostfs/hostfs_kern.c
> +++ b/fs/hostfs/hostfs_kern.c
> @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
> if (name == NULL)
> goto out_put;
>
> - fd = file_create(name, mode & S_IFMT);
> + fd = file_create(name, mode & 0777);

"(S_IRWXU | S_IRWXG | S_IRWXO)"?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/