Re: [PATCH 40/79] link_path_walk: turn inner loop into explicit goto

From: Linus Torvalds
Date: Tue May 05 2015 - 13:17:12 EST


On Mon, May 4, 2015 at 10:22 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> +l:

This looked like noise.

PLEASE. We're not programming in Pascal (and thank all Gods for that),
so we can have labels that have meaningful names. Also, we're not
ashamed of using goto where it makes sense, so we don't need to try to
hide the labels by making them look like specks of dirt on our
monitor.

So give the label a real name that describes what it is. Not this kind of thing.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/