Re: [PATCH 51/79] namei: remove restrictions on nesting depth

From: NeilBrown
Date: Tue May 05 2015 - 22:55:45 EST


On Tue, 5 May 2015 06:22:25 +0100 Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:

> From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
>
> The only restriction is that on the total amount of symlinks
> crossed; how they are nested does not matter
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> ---


> - if (unlikely(current->total_link_count >= 40)) {
> + if (unlikely(current->total_link_count >= MAXSYMLINKS)) {

There is still a literal '40' in follow_automount.

current->total_link_count++;
if (current->total_link_count >= 40)
return -ELOOP;


should that become MAXSYMLINKS too?

Thanks,
NeilBrown

Attachment: pgplqFf2NbUL8.pgp
Description: OpenPGP digital signature